feat(trader): add configurable profit drawdown close#1401
Open
nn87200 wants to merge 2 commits intoNoFxAiOS:devfrom
Open
feat(trader): add configurable profit drawdown close#1401nn87200 wants to merge 2 commits intoNoFxAiOS:devfrom
nn87200 wants to merge 2 commits intoNoFxAiOS:devfrom
Conversation
- Add EnableDrawdownClose, DrawdownCloseMinProfitPct, DrawdownClosePct to RiskControlConfig - Extract shouldTriggerDrawdownClose for configurable thresholds (defaults: 5% min profit, 40% pullback) - Add unit tests for drawdown close logic
- Add enable checkbox and min profit % / pullback % inputs to RiskControlEditor - Add RiskControlConfig fields to web types
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
What: Adds configurable profit drawdown close. Users can set min profit % and pullback from peak % in strategy risk control, with an enable/disable option.
Why: Allows per-strategy tuning of when positions are closed based on profit drawdown from peak, instead of fixed 5% min profit and 40% pullback.
🎯 Type of Change
🔗 Related Issues
📋 Changes Made
EnableDrawdownClose,DrawdownCloseMinProfitPct,DrawdownClosePcttoRiskControlConfigwith defaults (5%, 40%)shouldTriggerDrawdownClose()and wirecheckPositionDrawdown()to strategy configRiskControlConfigfields for drawdown close🧪 Testing
go test ./trader -run TestShouldTriggerDrawdownClose)Testing steps:
go test -v ./trader -run TestShouldTriggerDrawdownClose→ all 10 tests passgo test ./trader→ existing tests passnpm testin web → 108 tests pass✅ Checklist
Before Submitting
go build)go test ./trader)go fmt,go vet)devPR Template
📚 Additional Notes